spmallette commented on code in PR #3091:
URL: https://github.com/apache/tinkerpop/pull/3091#discussion_r2034196924
##########
gremlin-language/src/main/antlr4/Gremlin.g4:
##########
@@ -67,34 +73,34 @@ traversalSourceSelfMethod
;
traversalSourceSelfMethod_withBulk
- : 'withBulk' LPAREN booleanArgument RPAREN
+ : K_WITHBULK LPAREN booleanArgument RPAREN
;
traversalSourceSelfMethod_withPath
- : 'withPath' LPAREN RPAREN
+ : K_WITHPATH LPAREN RPAREN
;
traversalSourceSelfMethod_withSack
- : 'withSack' LPAREN genericLiteralArgument RPAREN
- | 'withSack' LPAREN genericLiteralArgument COMMA
traversalBiFunctionArgument RPAREN
+ : K_WITHSACK LPAREN genericLiteralArgument RPAREN
+ | K_WITHSACK LPAREN genericLiteralArgument COMMA traversalBiFunction RPAREN
;
traversalSourceSelfMethod_withSideEffect
- : 'withSideEffect' LPAREN stringArgument COMMA genericLiteralArgument
RPAREN
- | 'withSideEffect' LPAREN stringArgument COMMA genericLiteralArgument
COMMA traversalBiFunctionArgument RPAREN
+ : K_WITHSIDEEFFECT LPAREN stringArgument COMMA genericLiteralArgument
RPAREN
+ | K_WITHSIDEEFFECT LPAREN stringArgument COMMA genericLiteralArgument
COMMA traversalBiFunction RPAREN
Review Comment:
the intention is to break this (and other places) as we go about using
variables more judiciously and just where they make sense. arguments that are
enums aren't one of those places where variables will be used. they don't
really make sense there. the only reason Direction and T are in that case is
because of `mergeE/V` and their use inside the `Map` argument as a special
situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
