kenhuuu commented on code in PR #3242:
URL: https://github.com/apache/tinkerpop/pull/3242#discussion_r2437444926
##########
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.js:
##########
@@ -46,9 +46,10 @@ class Graph {
}
class Element {
- constructor(id, label) {
+ constructor(id, label, properties = undefined) {
Review Comment:
I might have to take back what I said. The check needs to stay there if we
are trying to prevent users from ever assigning null or undefined to
properties. So I guess it depends on what should be done if a user explicitly
tries to do something like `new Vertex("a", "b", null)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
