xiazcy commented on code in PR #3242:
URL: https://github.com/apache/tinkerpop/pull/3242#discussion_r2437456440


##########
gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.js:
##########
@@ -46,9 +46,10 @@ class Graph {
 }
 
 class Element {
-  constructor(id, label) {
+  constructor(id, label, properties = undefined) {

Review Comment:
   I think the undefined case is fine with either default but yea, the `null` 
check has to be present or else js wraps it into `[null]`. I might leave it as 
`[]` for clarity. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to