spmallette commented on code in PR #3242:
URL: https://github.com/apache/tinkerpop/pull/3242#discussion_r2445222447
##########
docs/src/upgrade/release-3.8.x.asciidoc:
##########
@@ -301,10 +301,27 @@ g.inject("Hello").split("")
See: link:https://issues.apache.org/jira/browse/TINKERPOP-3083[TINKERPOP-3083]
==== asString() No Longer Allow Nulls
-The `asString()` step will no longer allow `null` input. An
`IllegalArgumentException` will be thrown for consistency with all other
parsing steps (i.e. `asDate()`, `asBool()`, `asNumber()`).
+
+The `asString()` step will no longer allow `null` input. An
`IllegalArgumentException` will be thrown for consistency
+with all other parsing steps (i.e. `asDate()`, `asBool()`, `asNumber()`).
See:
link:https://lists.apache.org/thread/q76pgrvhprosb4lty63bnsnbw2ljyl7m[DISCUSS]
thread
+==== Properties on Element Serialization in Python & Javascript
+
+Element properties handling has been inconsistent across GLVs. Previously,
`gremlin-python` deserialized empty properties as `None`, while
Review Comment:
i think you should clarify that this is talking about situations where
properties on elements are enabled. rather than just referencing
"Elements.properties` please share an example. also rather than just declaring
it a "breaking change" with an explanation of what to do, work that into the
example.
the "Note:" at the end, i don't think formats as a "NOTE:" but i'm not sure
if you were meaning it that way or not. we usually don't use "NOTE:" in Upgrade
Docs as best i can recall. That aside, I think this is a good thought but i
don't think it will be clear to most users what that means. I think it would be
good to expand this part into a paragraph to better explain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
