xiazcy commented on code in PR #3211: URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2421211712
########## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/CompareType.java: ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tinkerpop.gremlin.process.traversal; + +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.ConcurrentHashMap; + +/** + * {@code CompareType} is a {@code BiPredicate} that determines whether the first argument is a type of the second argument. + * + */ +public enum CompareType implements PBiPredicate<Object, Class<?>> { + + /** + * Evaluates if the first object is an instance of the second class. + * + * @since 3.8.0 + */ + typeOf { + @Override + public boolean test(final Object first, final Class<?> second) { + if (first == null) { + return second == null; + } + return second != null && second.isAssignableFrom(first.getClass()); + } + + }; + + public static final class GlobalTypeCache { + + private GlobalTypeCache() { + throw new IllegalStateException("Utility class"); + } + + /** + * A register of enum names for all types. + */ + private static final Map<String, Class<?>> GLOBAL_TYPE_REGISTRY = new ConcurrentHashMap<>(); + + // register the GType classes for convinience use of simple class names in grammar + static { + for (GType value : GType.values()) { + if (value == GType.NULL) { + // skip the null type + continue; + } + registerDataType(value.getType()); + } + } + + /** + * Register a type with a custom name. Review Comment: I'm leaning towards removing this custom function, or restrict it to a defined convention, like Stephen mentioned, to something like `providerPrefix:simpleTypeName`, where the allowed input is just a custom `providerPrefix` string and we attach it to the simple name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
