spmallette commented on code in PR #3211: URL: https://github.com/apache/tinkerpop/pull/3211#discussion_r2377041849
########## gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Type.java: ########## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.tinkerpop.gremlin.process.traversal; + +import java.util.Map; +import java.util.Optional; +import java.util.concurrent.ConcurrentHashMap; + +/** + * {@code Type} is a {@code BiPredicate} that determines whether the first argument is a type of the second argument. + * + */ +public enum Type implements PBiPredicate<Object, Object> { Review Comment: I suppose we could sort of extend from` Compare` with specific other implementations. Either are better than taking `Type` so maybe see if anyone else favors `CompareType` over `InstanceOf`. I think it's worth keeping in mind that most users won't even see these predicates as they are just enums within `P`, so they are a layer lower than the primary API for Gremlin at least which take some pressure away from getting the naming perfect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
