[
https://issues.apache.org/jira/browse/TOMEE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713306#comment-16713306
]
ASF GitHub Bot commented on TOMEE-2337:
---------------------------------------
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r239953751
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java
---
@@ -24,14 +24,20 @@
@SuppressWarnings("PMD.OverrideBothEqualsAndHashcode")
public class FileUtils {
- private static final java.util.Random _random = new java.util.Random();
+ private static final java.util.Random RANDOM = new java.util.Random();
--- End diff --
That is not a static type. to be `RANDOM`
Also, could check if it makes sense to update to
[ThreadLocalRandom](https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadLocalRandom.html
)
> Code cleanup: module openejb-loader
> -----------------------------------
>
> Key: TOMEE-2337
> URL: https://issues.apache.org/jira/browse/TOMEE-2337
> Project: TomEE
> Issue Type: Improvement
> Affects Versions: 8.0.0-M1, 7.1.0
> Reporter: Hayri Cicek
> Priority: Trivial
> Labels: pull-request-available
>
> Use diamond operator, JavaDoc and if possible final variables/parameters
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
