[ 
https://issues.apache.org/jira/browse/TOMEE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713382#comment-16713382
 ] 

ASF GitHub Bot commented on TOMEE-2337:
---------------------------------------

Github user cicekhayri commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/262#discussion_r239968653
  
    --- Diff: 
container/openejb-loader/src/main/java/org/apache/openejb/loader/Files.java ---
    @@ -245,8 +356,8 @@ public static File mkdirs(final File file) {
         }
     
     
    -    // Shutdown hook for recursive delete on tmp directories
    -    static final List<String> delete = new ArrayList<String>();
    +    // Shutdown hook for recursive DELETE on tmp directories
    +    static final List<String> DELETE = new ArrayList<String>();
    --- End diff --
    
    absolutely 


> Code cleanup: module openejb-loader
> -----------------------------------
>
>                 Key: TOMEE-2337
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2337
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 8.0.0-M1, 7.1.0
>            Reporter: Hayri Cicek
>            Priority: Trivial
>              Labels: pull-request-available
>
> Use diamond operator, JavaDoc and if possible final variables/parameters



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to