[
https://issues.apache.org/jira/browse/TOMEE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713308#comment-16713308
]
ASF GitHub Bot commented on TOMEE-2337:
---------------------------------------
Github user otaviojava commented on a diff in the pull request:
https://github.com/apache/tomee/pull/262#discussion_r239954220
--- Diff:
container/openejb-loader/src/main/java/org/apache/openejb/loader/SystemInstance.java
---
@@ -263,7 +318,7 @@ public ClassLoader getClassLoader() {
return removed;
}
- private static final AtomicReference<SystemInstance> system = new
AtomicReference<SystemInstance>();
+ private static final AtomicReference<SystemInstance> SYSTEM = new
AtomicReference<SystemInstance>();
--- End diff --
Could you use a diamond operator?
`private static final AtomicReference<SystemInstance> SYSTEM = new
AtomicReference<>();`
> Code cleanup: module openejb-loader
> -----------------------------------
>
> Key: TOMEE-2337
> URL: https://issues.apache.org/jira/browse/TOMEE-2337
> Project: TomEE
> Issue Type: Improvement
> Affects Versions: 8.0.0-M1, 7.1.0
> Reporter: Hayri Cicek
> Priority: Trivial
> Labels: pull-request-available
>
> Use diamond operator, JavaDoc and if possible final variables/parameters
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
