[
https://issues.apache.org/jira/browse/TOMEE-4053?focusedWorklogId=824197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824197
]
ASF GitHub Bot logged work on TOMEE-4053:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/22 12:55
Start Date: 08/Nov/22 12:55
Worklog Time Spent: 10m
Work Description: rzo1 commented on code in PR #953:
URL: https://github.com/apache/tomee/pull/953#discussion_r1016594940
##########
pom.xml:
##########
@@ -1341,7 +1327,7 @@
<dependency>
<groupId>org.apache.geronimo.mail</groupId>
<artifactId>geronimo-mail_2.1_provider</artifactId>
- <version>${geronimo-mail_2.1_provider.version}</version>
+ <version>${version.geronimo-javamail_1.6_mail}</version>
Review Comment:
This version string doesn't look right? Might explain my confusion regarding
one of the dropped properties.
##########
pom.xml:
##########
@@ -102,28 +101,16 @@
<version.jakartaee-api>9.1-M2</version.jakartaee-api>
<version.tomee-patch-plugin>0.9</version.tomee-patch-plugin>
- <!--
- JavaMail is both API and IMPL so we don't have them in the jakartaee-api
uber jar.
- We decided to add them here in the project so we can patch/update the 2
libraries without having
- to update and release the jakartaee-api.jar. Different lifecycle.
- -->
- <geronimo-mail_2.1_spec.version>1.0.0-M1</geronimo-mail_2.1_spec.version>
-
<geronimo-mail_2.1_provider.version>1.0.0</geronimo-mail_2.1_provider.version>
Review Comment:
Any reason for dropping one of these versions? Guess we need to check, what
is needed / required.
##########
pom.xml:
##########
@@ -102,28 +101,16 @@
<version.jakartaee-api>9.1-M2</version.jakartaee-api>
<version.tomee-patch-plugin>0.9</version.tomee-patch-plugin>
- <!--
- JavaMail is both API and IMPL so we don't have them in the jakartaee-api
uber jar.
- We decided to add them here in the project so we can patch/update the 2
libraries without having
Review Comment:
Guess we should keep these comments
Issue Time Tracking
-------------------
Worklog Id: (was: 824197)
Time Spent: 5.5h (was: 5h 20m)
> Dependency properties cleanup
> -----------------------------
>
> Key: TOMEE-4053
> URL: https://issues.apache.org/jira/browse/TOMEE-4053
> Project: TomEE
> Issue Type: Improvement
> Reporter: Gwénaël Ruelland
> Priority: Minor
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Proposed PR for properties consistency
> * properties are of the form 'version.groupid' or 'groupid.version' :
> changed most to the 'version.groupid' form for coherence.
> * regrouping properties by feature blocks
> * ordering by name were usefull
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
