[ 
https://issues.apache.org/jira/browse/TOMEE-4053?focusedWorklogId=824220&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824220
 ]

ASF GitHub Bot logged work on TOMEE-4053:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Nov/22 14:17
            Start Date: 08/Nov/22 14:17
    Worklog Time Spent: 10m 
      Work Description: sultan commented on code in PR #953:
URL: https://github.com/apache/tomee/pull/953#discussion_r1016690389


##########
pom.xml:
##########
@@ -102,28 +101,16 @@
     <version.jakartaee-api>9.1-M2</version.jakartaee-api>
     <version.tomee-patch-plugin>0.9</version.tomee-patch-plugin>
 
-    <!--
-      JavaMail is both API and IMPL so we don't have them in the jakartaee-api 
uber jar.
-      We decided to add them here in the project so we can patch/update the 2 
libraries without having
-      to update and release the jakartaee-api.jar. Different lifecycle.
-    -->
-    <geronimo-mail_2.1_spec.version>1.0.0-M1</geronimo-mail_2.1_spec.version>
-    
<geronimo-mail_2.1_provider.version>1.0.0</geronimo-mail_2.1_provider.version>

Review Comment:
   relevant question, they are not dropped but moved, i redid the PR again and 
fixed the props names





Issue Time Tracking
-------------------

    Worklog Id:     (was: 824220)
    Time Spent: 6h 10m  (was: 6h)

> Dependency properties cleanup
> -----------------------------
>
>                 Key: TOMEE-4053
>                 URL: https://issues.apache.org/jira/browse/TOMEE-4053
>             Project: TomEE
>          Issue Type: Improvement
>            Reporter: Gwénaël Ruelland
>            Priority: Minor
>          Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> Proposed PR for properties consistency 
>  * properties are of the form 'version.groupid' or 'groupid.version' : 
> changed most to the 'version.groupid' form for coherence.
>  * regrouping properties by feature blocks
>  * ordering by name were usefull



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to