[
https://issues.apache.org/jira/browse/TOMEE-4053?focusedWorklogId=824219&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824219
]
ASF GitHub Bot logged work on TOMEE-4053:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Nov/22 14:16
Start Date: 08/Nov/22 14:16
Worklog Time Spent: 10m
Work Description: sultan commented on code in PR #953:
URL: https://github.com/apache/tomee/pull/953#discussion_r1016687887
##########
pom.xml:
##########
@@ -102,28 +101,16 @@
<version.jakartaee-api>9.1-M2</version.jakartaee-api>
<version.tomee-patch-plugin>0.9</version.tomee-patch-plugin>
- <!--
- JavaMail is both API and IMPL so we don't have them in the jakartaee-api
uber jar.
- We decided to add them here in the project so we can patch/update the 2
libraries without having
Review Comment:
we should not rely on the API from Impl but the API from Jakarta API which
has both Jakarta Mail API and Jakarta Activation API available, i believe we
should not take the API from geronimo.
This is something i itented to change on another step.
might i try on this PR ?
##########
pom.xml:
##########
@@ -102,28 +101,16 @@
<version.jakartaee-api>9.1-M2</version.jakartaee-api>
<version.tomee-patch-plugin>0.9</version.tomee-patch-plugin>
- <!--
- JavaMail is both API and IMPL so we don't have them in the jakartaee-api
uber jar.
- We decided to add them here in the project so we can patch/update the 2
libraries without having
Review Comment:
we should not rely on the API from Impl but the API from Jakarta API which
has both Jakarta Mail API and Jakarta Activation API available, i believe we
should not take the API from geronimo.
This is something i intented to change on another step.
might i try on this PR ?
Issue Time Tracking
-------------------
Worklog Id: (was: 824219)
Time Spent: 6h (was: 5h 50m)
> Dependency properties cleanup
> -----------------------------
>
> Key: TOMEE-4053
> URL: https://issues.apache.org/jira/browse/TOMEE-4053
> Project: TomEE
> Issue Type: Improvement
> Reporter: Gwénaël Ruelland
> Priority: Minor
> Time Spent: 6h
> Remaining Estimate: 0h
>
> Proposed PR for properties consistency
> * properties are of the form 'version.groupid' or 'groupid.version' :
> changed most to the 'version.groupid' form for coherence.
> * regrouping properties by feature blocks
> * ordering by name were usefull
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
