changeset 3439c45d4e07 in modules/account_dunning:default
details:
https://hg.tryton.org/modules/account_dunning?cmd=changeset;node=3439c45d4e07
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 30 +++++++++++++++---------------
account.py | 2 --
dunning.py | 5 +----
party.py | 1 -
setup.py | 7 ++++---
tests/__init__.py | 2 +-
7 files changed, 23 insertions(+), 26 deletions(-)
diffs (131 lines):
diff -r d40e44ee0e81 -r 3439c45d4e07 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r d40e44ee0e81 -r 3439c45d4e07 __init__.py
--- a/__init__.py Fri Dec 06 17:33:46 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,25 +2,25 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .dunning import *
-from .party import *
-from .account import *
+from . import dunning
+from . import party
+from . import account
def register():
Pool.register(
- Procedure,
- Level,
- Dunning,
- CreateDunningStart,
- ProcessDunningStart,
- Party,
- PartyDunningProcedure,
- Configuration,
- ConfigurationDefaultDunningProcedure,
- MoveLine,
+ dunning.Procedure,
+ dunning.Level,
+ dunning.Dunning,
+ dunning.CreateDunningStart,
+ dunning.ProcessDunningStart,
+ party.Party,
+ party.PartyDunningProcedure,
+ account.Configuration,
+ account.ConfigurationDefaultDunningProcedure,
+ account.MoveLine,
module='account_dunning', type_='model')
Pool.register(
- CreateDunning,
- ProcessDunning,
+ dunning.CreateDunning,
+ dunning.ProcessDunning,
module='account_dunning', type_='wizard')
diff -r d40e44ee0e81 -r 3439c45d4e07 account.py
--- a/account.py Fri Dec 06 17:33:46 2019 +0100
+++ b/account.py Sun Mar 01 12:33:51 2020 +0100
@@ -3,8 +3,6 @@
from trytond.pool import PoolMeta
from trytond.model import ModelSQL, ValueMixin, fields
-
-__all__ = ['Configuration', 'ConfigurationDefaultDunningProcedure', 'MoveLine']
default_dunning_procedure = fields.Many2One(
'account.dunning.procedure', "Default Dunning Procedure",
help="The default dunning procedure for new customers.")
diff -r d40e44ee0e81 -r 3439c45d4e07 dunning.py
--- a/dunning.py Fri Dec 06 17:33:46 2019 +0100
+++ b/dunning.py Sun Mar 01 12:33:51 2020 +0100
@@ -13,10 +13,6 @@
Button
from trytond.pool import Pool
-__all__ = ['Procedure', 'Level', 'Dunning',
- 'CreateDunningStart', 'CreateDunning',
- 'ProcessDunningStart', 'ProcessDunning']
-
class Procedure(ModelSQL, ModelView):
'Account Dunning Procedure'
@@ -67,6 +63,7 @@
if self.overdue is not None:
return (date - line.maturity_date) >= self.overdue
+
_STATES = {
'readonly': Eval('state') != 'draft',
}
diff -r d40e44ee0e81 -r 3439c45d4e07 party.py
--- a/party.py Fri Dec 06 17:33:46 2019 +0100
+++ b/party.py Sun Mar 01 12:33:51 2020 +0100
@@ -5,7 +5,6 @@
from trytond.pool import PoolMeta, Pool
from trytond.tools.multivalue import migrate_property
-__all__ = ['Party', 'PartyDunningProcedure']
dunning_procedure = fields.Many2One(
'account.dunning.procedure', "Dunning Procedure")
diff -r d40e44ee0e81 -r 3439c45d4e07 setup.py
--- a/setup.py Fri Dec 06 17:33:46 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -79,8 +79,8 @@
keywords='tryton account dunning',
package_dir={'trytond.modules.account_dunning': '.'},
packages=(
- ['trytond.modules.account_dunning'] +
- ['trytond.modules.account_dunning.%s' % p for p in find_packages()]
+ ['trytond.modules.account_dunning']
+ + ['trytond.modules.account_dunning.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.account_dunning': (info.get('xml', [])
@@ -93,7 +93,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r d40e44ee0e81 -r 3439c45d4e07 tests/__init__.py
--- a/tests/__init__.py Fri Dec 06 17:33:46 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.account_dunning.tests.test_account_dunning import
suite
+ from trytond.modules.account_dunning.tests.test_account_dunning import
suite # noqa: E501
except ImportError:
from .test_account_dunning import suite
