changeset 00b1c38bedf8 in modules/account_deposit:default
details:
https://hg.tryton.org/modules/account_deposit?cmd=changeset;node=00b1c38bedf8
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 12 ++++++------
invoice.py | 3 ---
party.py | 5 +----
setup.py | 7 ++++---
tests/__init__.py | 2 +-
6 files changed, 14 insertions(+), 17 deletions(-)
diffs (107 lines):
diff -r 1ef824075445 -r 00b1c38bedf8 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 1ef824075445 -r 00b1c38bedf8 __init__.py
--- a/__init__.py Wed Dec 04 11:09:34 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -3,7 +3,7 @@
from trytond.pool import Pool
from . import account
-from .invoice import *
+from . import invoice
from . import party
@@ -11,12 +11,12 @@
Pool.register(
account.AccountTypeTemplate,
account.AccountType,
- Invoice,
- InvoiceLine,
- DepositRecallStart,
+ invoice.Invoice,
+ invoice.InvoiceLine,
+ invoice.DepositRecallStart,
party.Party,
module='account_deposit', type_='model')
Pool.register(
- DepositRecall,
- party.PartyErase,
+ invoice.DepositRecall,
+ party.Erase,
module='account_deposit', type_='wizard')
diff -r 1ef824075445 -r 00b1c38bedf8 invoice.py
--- a/invoice.py Wed Dec 04 11:09:34 2019 +0100
+++ b/invoice.py Sun Mar 01 12:33:51 2020 +0100
@@ -9,9 +9,6 @@
from .exceptions import DepositError
-__all__ = ['Invoice', 'InvoiceLine',
- 'DepositRecall', 'DepositRecallStart']
-
class Invoice(metaclass=PoolMeta):
__name__ = 'account.invoice'
diff -r 1ef824075445 -r 00b1c38bedf8 party.py
--- a/party.py Wed Dec 04 11:09:34 2019 +0100
+++ b/party.py Sun Mar 01 12:33:51 2020 +0100
@@ -16,9 +16,6 @@
from trytond.modules.party.exceptions import EraseError
-__all__ = ['Party', 'PartyErase']
-
-
class Party(metaclass=PoolMeta):
__name__ = 'party.party'
@@ -142,7 +139,7 @@
return not amount or ((amount < 0) == (sign < 0))
-class PartyErase(metaclass=PoolMeta):
+class Erase(metaclass=PoolMeta):
__name__ = 'party.erase'
def check_erase_company(self, party, company):
diff -r 1ef824075445 -r 00b1c38bedf8 setup.py
--- a/setup.py Wed Dec 04 11:09:34 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -79,8 +79,8 @@
keywords='tryton account deposit',
package_dir={'trytond.modules.account_deposit': '.'},
packages=(
- ['trytond.modules.account_deposit'] +
- ['trytond.modules.account_deposit.%s' % p for p in find_packages()]
+ ['trytond.modules.account_deposit']
+ + ['trytond.modules.account_deposit.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.account_deposit': (info.get('xml', [])
@@ -94,7 +94,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 1ef824075445 -r 00b1c38bedf8 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:34 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.account_deposit.tests.test_account_deposit import
suite
+ from trytond.modules.account_deposit.tests.test_account_deposit import
suite # noqa: E501
except ImportError:
from .test_account_deposit import suite
