changeset ae5cce2a22c9 in modules/analytic_invoice:default
details:
https://hg.tryton.org/modules/analytic_invoice?cmd=changeset;node=ae5cce2a22c9
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
asset.py | 2 --
invoice.py | 2 --
setup.py | 7 ++++---
tests/__init__.py | 2 +-
5 files changed, 7 insertions(+), 8 deletions(-)
diffs (66 lines):
diff -r b8e2178f5b64 -r ae5cce2a22c9 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r b8e2178f5b64 -r ae5cce2a22c9 asset.py
--- a/asset.py Wed Dec 04 11:09:35 2019 +0100
+++ b/asset.py Sun Mar 01 12:33:52 2020 +0100
@@ -6,8 +6,6 @@
from trytond.modules.analytic_account import AnalyticMixin
-__all__ = ['Asset']
-
class Asset(AnalyticMixin, metaclass=PoolMeta):
__name__ = 'account.asset'
diff -r b8e2178f5b64 -r ae5cce2a22c9 invoice.py
--- a/invoice.py Wed Dec 04 11:09:35 2019 +0100
+++ b/invoice.py Sun Mar 01 12:33:52 2020 +0100
@@ -6,8 +6,6 @@
from trytond.modules.analytic_account import AnalyticMixin
-__all__ = ['InvoiceLine', 'AnalyticAccountEntry']
-
class InvoiceLine(AnalyticMixin, metaclass=PoolMeta):
__name__ = 'account.invoice.line'
diff -r b8e2178f5b64 -r ae5cce2a22c9 setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -81,8 +81,8 @@
keywords='tryton analytic account invoice',
package_dir={'trytond.modules.analytic_invoice': '.'},
packages=(
- ['trytond.modules.analytic_invoice'] +
- ['trytond.modules.analytic_invoice.%s' % p for p in find_packages()]
+ ['trytond.modules.analytic_invoice']
+ + ['trytond.modules.analytic_invoice.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.analytic_invoice': (info.get('xml', [])
@@ -95,7 +95,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r b8e2178f5b64 -r ae5cce2a22c9 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.analytic_invoice.tests.test_analytic_invoice import
suite
+ from trytond.modules.analytic_invoice.tests.test_analytic_invoice import
suite # noqa: E501
except ImportError:
from .test_analytic_invoice import suite
