changeset ccad014bba85 in modules/commission_waiting:default
details:
https://hg.tryton.org/modules/commission_waiting?cmd=changeset;node=ccad014bba85
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 16 ++++++++--------
account.py | 2 --
commission.py | 4 ----
invoice.py | 3 ---
setup.py | 8 +++++---
tests/__init__.py | 2 +-
7 files changed, 16 insertions(+), 21 deletions(-)
diffs (116 lines):
diff -r fd4cb3de1d58 -r ccad014bba85 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r fd4cb3de1d58 -r ccad014bba85 __init__.py
--- a/__init__.py Sat Dec 28 17:48:50 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,16 +2,16 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .commission import *
-from .invoice import *
-from .account import *
+from . import commission
+from . import invoice
+from . import account
def register():
Pool.register(
- Agent,
- Commission,
- Invoice,
- InvoiceLine,
- Move,
+ commission.Agent,
+ commission.Commission,
+ invoice.Invoice,
+ invoice.InvoiceLine,
+ account.Move,
module='commission_waiting', type_='model')
diff -r fd4cb3de1d58 -r ccad014bba85 account.py
--- a/account.py Sat Dec 28 17:48:50 2019 +0100
+++ b/account.py Sun Mar 01 12:33:52 2020 +0100
@@ -3,8 +3,6 @@
from trytond.pool import PoolMeta
-__all__ = ['Move']
-
class Move(metaclass=PoolMeta):
__name__ = 'account.move'
diff -r fd4cb3de1d58 -r ccad014bba85 commission.py
--- a/commission.py Sat Dec 28 17:48:50 2019 +0100
+++ b/commission.py Sun Mar 01 12:33:52 2020 +0100
@@ -1,16 +1,12 @@
# This file is part of Tryton. The COPYRIGHT file at the top level of
# this repository contains the full copyright notices and license terms.
-
from trytond.pool import PoolMeta, Pool
from trytond.model import ModelView, fields
from trytond.pyson import Eval, Bool
from trytond.transaction import Transaction
-__all__ = ['Agent', 'Commission']
-
-
class Agent(metaclass=PoolMeta):
__name__ = 'commission.agent'
waiting_account = fields.Many2One('account.account', 'Waiting Account',
diff -r fd4cb3de1d58 -r ccad014bba85 invoice.py
--- a/invoice.py Sat Dec 28 17:48:50 2019 +0100
+++ b/invoice.py Sun Mar 01 12:33:52 2020 +0100
@@ -7,9 +7,6 @@
from trytond.model import ModelView, Workflow
-__all__ = ['Invoice', 'InvoiceLine']
-
-
class Invoice(metaclass=PoolMeta):
__name__ = 'account.invoice'
diff -r fd4cb3de1d58 -r ccad014bba85 setup.py
--- a/setup.py Sat Dec 28 17:48:50 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -79,8 +79,9 @@
keywords='tryton commission',
package_dir={'trytond.modules.commission_waiting': '.'},
packages=(
- ['trytond.modules.commission_waiting'] +
- ['trytond.modules.commission_waiting.%s' % p for p in find_packages()]
+ ['trytond.modules.commission_waiting']
+ + ['trytond.modules.commission_waiting.%s' % p
+ for p in find_packages()]
),
package_data={
'trytond.modules.commission_waiting': (info.get('xml', [])
@@ -93,7 +94,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r fd4cb3de1d58 -r ccad014bba85 tests/__init__.py
--- a/tests/__init__.py Sat Dec 28 17:48:50 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -1,7 +1,7 @@
# This file is part of Tryton. The COPYRIGHT file at the top level of
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.commission_waiting.tests.test_commission_waiting
import suite
+ from trytond.modules.commission_waiting.tests.test_commission_waiting
import suite # noqa: E501
except ImportError:
from .test_commission_waiting import suite
