changeset 273098bd6410 in modules/carrier_weight:default
details:
https://hg.tryton.org/modules/carrier_weight?cmd=changeset;node=273098bd6410
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
carrier.py | 2 --
sale.py | 2 --
setup.py | 7 ++++---
stock.py | 2 --
5 files changed, 6 insertions(+), 9 deletions(-)
diffs (66 lines):
diff -r ecfeae6e7528 -r 273098bd6410 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r ecfeae6e7528 -r 273098bd6410 carrier.py
--- a/carrier.py Wed Dec 04 11:09:35 2019 +0100
+++ b/carrier.py Sun Mar 01 12:33:52 2020 +0100
@@ -7,8 +7,6 @@
from trytond.pool import Pool, PoolMeta
from trytond.transaction import Transaction
-__all__ = ['Carrier', 'WeightPriceList']
-
class Carrier(metaclass=PoolMeta):
__name__ = 'carrier'
diff -r ecfeae6e7528 -r 273098bd6410 sale.py
--- a/sale.py Wed Dec 04 11:09:35 2019 +0100
+++ b/sale.py Sun Mar 01 12:33:52 2020 +0100
@@ -7,8 +7,6 @@
from .common import parcel_weight
-__all__ = ['Sale']
-
class Sale(metaclass=PoolMeta):
__name__ = 'sale.sale'
diff -r ecfeae6e7528 -r 273098bd6410 setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -81,8 +81,8 @@
keywords='tryton carrier weight',
package_dir={'trytond.modules.carrier_weight': '.'},
packages=(
- ['trytond.modules.carrier_weight'] +
- ['trytond.modules.carrier_weight.%s' % p for p in find_packages()]
+ ['trytond.modules.carrier_weight']
+ + ['trytond.modules.carrier_weight.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.carrier_weight': (info.get('xml', [])
@@ -96,7 +96,8 @@
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r ecfeae6e7528 -r 273098bd6410 stock.py
--- a/stock.py Wed Dec 04 11:09:35 2019 +0100
+++ b/stock.py Sun Mar 01 12:33:52 2020 +0100
@@ -7,8 +7,6 @@
from .common import parcel_weight
-__all__ = ['ShipmentIn', 'ShipmentOut']
-
class ShipmentIn(metaclass=PoolMeta):
__name__ = 'stock.shipment.in'
