changeset c17b751fef89 in modules/account_tax_cash:default
details:
https://hg.tryton.org/modules/account_tax_cash?cmd=changeset;node=c17b751fef89
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
account.py | 4 ++--
setup.py | 7 ++++---
tests/__init__.py | 2 +-
4 files changed, 9 insertions(+), 6 deletions(-)
diffs (58 lines):
diff -r 55c2ca22ff7e -r c17b751fef89 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 55c2ca22ff7e -r c17b751fef89 account.py
--- a/account.py Wed Dec 04 11:09:35 2019 +0100
+++ b/account.py Sun Mar 01 12:33:51 2020 +0100
@@ -103,10 +103,10 @@
periods = context.get('periods', [])
where = super(Tax, cls)._amount_where(tax_line, move_line, move)
return ((where
- & (tax_line.on_cash_basis == False)
+ & (tax_line.on_cash_basis == Literal(False))
| (tax_line.on_cash_basis == Null))
| ((tax_line.period.in_(periods) if periods else Literal(False))
- & (tax_line.on_cash_basis == True)))
+ & (tax_line.on_cash_basis == Literal(True))))
@classmethod
def _amount_domain(cls):
diff -r 55c2ca22ff7e -r c17b751fef89 setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -79,8 +79,8 @@
keywords='tryton account tax cash',
package_dir={'trytond.modules.account_tax_cash': '.'},
packages=(
- ['trytond.modules.account_tax_cash'] +
- ['trytond.modules.account_tax_cash.%s' % p for p in find_packages()]
+ ['trytond.modules.account_tax_cash']
+ + ['trytond.modules.account_tax_cash.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.account_tax_cash': (info.get('xml', [])
@@ -94,7 +94,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Czech',
diff -r 55c2ca22ff7e -r c17b751fef89 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.account_tax_cash.tests.test_account_tax_cash import
suite
+ from trytond.modules.account_tax_cash.tests.test_account_tax_cash import
suite # noqa: E501
except ImportError:
from .test_account_tax_cash import suite
