changeset 44b4639cf007 in modules/ldap_authentication:default
details:
https://hg.tryton.org/modules/ldap_authentication?cmd=changeset;node=44b4639cf007
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 4 ++--
res.py | 2 --
setup.py | 8 +++++---
4 files changed, 9 insertions(+), 7 deletions(-)
diffs (59 lines):
diff -r 39f7d520a58e -r 44b4639cf007 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 39f7d520a58e -r 44b4639cf007 __init__.py
--- a/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,10 +2,10 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .res import *
+from . import res
def register():
Pool.register(
- User,
+ res.User,
module='ldap_authentication', type_='model')
diff -r 39f7d520a58e -r 44b4639cf007 res.py
--- a/res.py Wed Dec 04 11:09:35 2019 +0100
+++ b/res.py Sun Mar 01 12:33:52 2020 +0100
@@ -13,8 +13,6 @@
from trytond.config import config, parse_uri
from trytond.exceptions import LoginException
-__all__ = ['User']
-
logger = logging.getLogger(__name__)
section = 'ldap_authentication'
diff -r 39f7d520a58e -r 44b4639cf007 setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -79,8 +79,9 @@
keywords='tryton ldap authentication',
package_dir={'trytond.modules.ldap_authentication': '.'},
packages=(
- ['trytond.modules.ldap_authentication'] +
- ['trytond.modules.ldap_authentication.%s' % p for p in find_packages()]
+ ['trytond.modules.ldap_authentication']
+ + ['trytond.modules.ldap_authentication.%s' % p
+ for p in find_packages()]
),
package_data={
'trytond.modules.ldap_authentication': (info.get('xml', [])
@@ -93,7 +94,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
