changeset c00e3153c5eb in modules/party_relationship:default
details:
https://hg.tryton.org/modules/party_relationship?cmd=changeset;node=c00e3153c5eb
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 4 ++--
party.py | 13 ++++++-------
setup.py | 8 +++++---
tests/__init__.py | 2 +-
5 files changed, 16 insertions(+), 13 deletions(-)
diffs (107 lines):
diff -r 8732e848f43a -r c00e3153c5eb .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 8732e848f43a -r c00e3153c5eb __init__.py
--- a/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -7,7 +7,7 @@
def register():
Pool.register(
party.RelationType,
- party.PartyRelation,
- party.PartyRelationAll,
+ party.Relation,
+ party.RelationAll,
party.Party,
module='party_relationship', type_='model')
diff -r 8732e848f43a -r c00e3153c5eb party.py
--- a/party.py Wed Dec 04 11:09:35 2019 +0100
+++ b/party.py Sun Mar 01 12:33:52 2020 +0100
@@ -6,8 +6,6 @@
from trytond.model import ModelSQL, ModelView, fields
from trytond.transaction import Transaction
-__all__ = ['RelationType', 'PartyRelation', 'PartyRelationAll', 'Party']
-
class RelationType(ModelSQL, ModelView):
'Relation Type'
@@ -19,7 +17,7 @@
help="Create automatically the reverse relation.")
-class PartyRelation(ModelSQL):
+class Relation(ModelSQL):
'Party Relation'
__name__ = 'party.relation'
@@ -43,7 +41,7 @@
]
-class PartyRelationAll(PartyRelation, ModelView):
+class RelationAll(Relation, ModelView):
'Party Relation'
__name__ = 'party.relation.all'
@@ -62,8 +60,8 @@
reverse_tables = {
None: (relation, None),
'type': {
- None: (type, (relation.type == type.id) &
- (type.reverse != Null)),
+ None: (type, (relation.type == type.id)
+ & (type.reverse != Null)),
},
}
@@ -192,7 +190,8 @@
# Clean cursor cache
for cache in list(Transaction().cache.values()):
- for cache in (cache, list(cache.get('_language_cache',
{}).values())):
+ for cache in (cache,
+ list(cache.get('_language_cache', {}).values())):
if cls.__name__ in cache:
for record in relations:
for record_id in (record.id, record.reverse_id):
diff -r 8732e848f43a -r c00e3153c5eb setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -79,8 +79,9 @@
keywords='tryton party relationship',
package_dir={'trytond.modules.party_relationship': '.'},
packages=(
- ['trytond.modules.party_relationship'] +
- ['trytond.modules.party_relationship.%s' % p for p in find_packages()]
+ ['trytond.modules.party_relationship']
+ + ['trytond.modules.party_relationship.%s' % p
+ for p in find_packages()]
),
package_data={
'trytond.modules.party_relationship': (info.get('xml', [])
@@ -93,7 +94,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 8732e848f43a -r c00e3153c5eb tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.party_relationship.tests.test_party_relationship
import suite
+ from trytond.modules.party_relationship.tests.test_party_relationship
import suite # noqa: E501
except ImportError:
from .test_party_relationship import suite
