changeset b757f4539b96 in modules/product_classification:default
details:
https://hg.tryton.org/modules/product_classification?cmd=changeset;node=b757f4539b96
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 10 +++++-----
product.py | 3 ---
setup.py | 7 ++++---
tests/__init__.py | 2 +-
5 files changed, 12 insertions(+), 12 deletions(-)
diffs (77 lines):
diff -r cf950e9c3cf2 -r b757f4539b96 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r cf950e9c3cf2 -r b757f4539b96 __init__.py
--- a/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,13 +2,13 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .product import *
+from . import product
def register():
Pool.register(
- Template,
- Product,
- ClassificationDummy,
- ClassificationTreeDummy,
+ product.Template,
+ product.Product,
+ product.ClassificationDummy,
+ product.ClassificationTreeDummy,
module='product_classification', type_='model')
diff -r cf950e9c3cf2 -r b757f4539b96 product.py
--- a/product.py Wed Dec 04 11:09:36 2019 +0100
+++ b/product.py Sun Mar 01 12:33:52 2020 +0100
@@ -5,9 +5,6 @@
from trytond.pool import PoolMeta, Pool
from trytond.pyson import Eval
-__all__ = ['ClassificationMixin', 'classification_tree',
- 'Template', 'Product', 'ClassificationDummy', 'ClassificationTreeDummy']
-
class ClassificationMixin(DeactivableMixin):
__slots__ = ()
diff -r cf950e9c3cf2 -r b757f4539b96 setup.py
--- a/setup.py Wed Dec 04 11:09:36 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -78,8 +78,8 @@
keywords='tryton product classification',
package_dir={'trytond.modules.product_classification': '.'},
packages=(
- ['trytond.modules.product_classification'] +
- ['trytond.modules.product_classification.%s' % p
+ ['trytond.modules.product_classification']
+ + ['trytond.modules.product_classification.%s' % p
for p in find_packages()]
),
package_data={
@@ -91,7 +91,8 @@
'Environment :: Plugins',
'Framework :: Tryton',
'Intended Audience :: Developers',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r cf950e9c3cf2 -r b757f4539b96 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.product_classification.tests.test_product_classification import
suite
+ from
trytond.modules.product_classification.tests.test_product_classification import
suite # noqa: E501
except ImportError:
from .test_product_classification import suite
