changeset d98bc405f011 in sao:default
details: https://hg.tryton.org/sao?cmd=changeset&node=d98bc405f011
description:
        Do not remove record from the looped list when setting list ids

        issue10638
        review358561002
diffstat:

 src/model.js |  7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diffs (22 lines):

diff -r e17551493004 -r d98bc405f011 src/model.js
--- a/src/model.js      Mon Aug 09 13:21:37 2021 +0200
+++ b/src/model.js      Wed Aug 11 18:02:25 2021 +0200
@@ -2165,12 +2165,17 @@
                 }
             }
             if (mode == 'list ids') {
+                var records_to_remove = [];
                 for (var i = 0, len = group.length; i < len; i++) {
                     var old_record = group[i];
                     if (!~value.indexOf(old_record.id)) {
-                        group.remove(old_record, true, true, false, false);
+                        records_to_remove.push(old_record);
                     }
                 }
+                for (i = 0, len = records_to_remove.length; i < len; i++) {
+                    var record_to_remove = records_to_remove[i];
+                    group.remove(record_to_remove, true, true, false, false);
+                }
                 group.load(value, modified || default_);
             } else {
                 value.forEach(function(vals) {

Reply via email to