changeset fd10b051b6b8 in tryton:default
details: https://hg.tryton.org/tryton?cmd=changeset&node=fd10b051b6b8
description:
        Do not remove record from the looped list when setting list ids

        issue10638
        review358561002
diffstat:

 tryton/gui/window/view_form/model/field.py |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (16 lines):

diff -r dfc153284a5e -r fd10b051b6b8 tryton/gui/window/view_form/model/field.py
--- a/tryton/gui/window/view_form/model/field.py        Fri Aug 06 09:52:18 
2021 +0200
+++ b/tryton/gui/window/view_form/model/field.py        Wed Aug 11 18:02:25 
2021 +0200
@@ -681,9 +681,9 @@
                 group.load_fields(fields)
 
         if mode == 'list ids':
-            for old_record in group:
-                if old_record.id not in value:
-                    group.remove(old_record, remove=True, signal=False)
+            records_to_remove = [r for r in group if r.id not in value]
+            for record_to_remove in records_to_remove:
+                group.remove(record_to_remove, remove=True, signal=False)
             group.load(value, modified=modified or default)
         else:
             for vals in value:

Reply via email to