soiferj commented on a change in pull request #4258: [WIP][TVM] Bring Your Own
Codegen to TVM
URL: https://github.com/apache/incubator-tvm/pull/4258#discussion_r343172649
##########
File path: include/tvm/relay/attrs/annotation.h
##########
@@ -57,6 +57,19 @@ struct CastHintAttrs : public tvm::AttrsNode<CastHintAttrs>
{
}
};
+/*!
+ * \brief Options for the subgraph operators.
+ */
+struct SubgraphAttrs : public tvm::AttrsNode<SubgraphAttrs> {
Review comment:
I feel like `SubgraphAttrs` can be used in a more generic way than just
specifying the third-party compiler. For example, specifying whether a given op
should run on GPU 1 vs GPU 2. Maybe we can rename the field `id` and update the
description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
