soiferj commented on a change in pull request #4258: [WIP][TVM] Bring Your Own Codegen to TVM URL: https://github.com/apache/incubator-tvm/pull/4258#discussion_r343196979
########## File path: src/relay/pass/extern_op.cc ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * Copyright (c) 2019 by Contributors + * \file src/relay/pass/extern_op.cc + * \brief Wraps a call with subgraph_begin and subgraph_end to indicate that + * the op of this call node will use external compiler. + */ + +#include <tvm/operation.h> +#include <tvm/relay/attrs/annotation.h> +#include <tvm/relay/expr_functor.h> +#include <tvm/relay/op_attr_types.h> +#include <tvm/relay/transform.h> + +namespace tvm { +namespace relay { +namespace extern_op { + +// A helper class to insert annotation boundaries for subgraphs. +class ExternOpWrapper : public ExprMutator { + public: + explicit ExternOpWrapper(const std::string& compiler) : compiler_(compiler) {} + + Expr VisitExpr_(const CallNode* cn) { + auto new_e = ExprMutator::VisitExpr_(cn); + + Call call = Downcast<Call>(new_e); + static auto fextern = Op::GetAttr<FTVMExternOp>("FTVMExternOp"); + Op op = Downcast<Op>(call->op); + CHECK(op.operator->()); + + if (fextern.count(op)) { + bool external = fextern[op](call->attrs, call->args, compiler_); + if (external) { + tvm::Array<tvm::relay::Expr> subgraph_begins; + for (const auto& it : call->args) { + const auto* begin_op = + runtime::Registry::Get("relay.op.annotation._make.subgraph_begin"); + CHECK(begin_op); + Expr begin = (*begin_op)(it, compiler_); + subgraph_begins.push_back(begin); + } + Expr update_call = CallNode::make(call->op, subgraph_begins, call->attrs); + const auto* end_op = + runtime::Registry::Get("relay.op.annotation._make.subgraph_end"); + CHECK(end_op); + Expr end = (*end_op)(update_call, compiler_); + return end; + } + } else { + LOG(WARNING) << op.operator->()->name << " in " << compiler_ << " is not registered"; + } + return new_e; + } + + private: + std::string compiler_; +}; + +Expr ExternOp(const Expr& expr, const std::string& compiler) { + return ExternOpWrapper(compiler).Mutate(expr); +} + +} // namespace extern_op + +namespace transform { + +Pass ExternOp(const std::string& compiler) { Review comment: Would you be able to share an example graph json before adding in these annotations and after? I feel like it would help to visualize it :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
