soiferj commented on a change in pull request #4258: [WIP][TVM] Bring Your Own Codegen to TVM URL: https://github.com/apache/incubator-tvm/pull/4258#discussion_r343179357
########## File path: python/tvm/relay/op/contrib/dnnl/extern_op.py ########## @@ -0,0 +1,50 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# pylint: disable=invalid-name, unused-argument +"""CBLAS library supported operators.""" +from __future__ import absolute_import + + +def conv2d(attrs, args): + """Check if the external codegen should be used. + """ + return True + + +def dense(attrs, args): + """Check if the external codegen should be used. + """ + return True + + +def relu(attrs, args): + """Check if the external codegen should be used. + """ + return True + + +def batch_norm(attrs, args): + """Check if the external codegen should be used. + FIXME: Turn off due to not support of multiple outputs. + """ + return False Review comment: Is there a purpose to returning false? Could this function just be removed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
