masahi commented on a change in pull request #4418: [RUNTIME] Add cudnn conv3d
URL: https://github.com/apache/incubator-tvm/pull/4418#discussion_r352031235
##########
File path: src/runtime/contrib/cudnn/conv_forward.cc
##########
@@ -22,31 +22,29 @@
*/
#include <tvm/runtime/registry.h>
#include <tvm/runtime/util.h>
+#include <tvm/packed_func_ext.h>
+#include <tvm/ir.h>
#include <tvm/runtime/device_api.h>
#include "cudnn_utils.h"
namespace tvm {
namespace contrib {
using namespace runtime;
+using tvm::ir::IntImm;
-
-TVM_REGISTER_GLOBAL("tvm.contrib.cudnn.conv2d.forward")
-.set_body([](TVMArgs args, TVMRetValue *ret) {
- int mode = args[0];
- int format = args[1];
- int algo = args[2];
- int pad_h = args[3];
- int pad_w = args[4];
- int stride_h = args[5];
- int stride_w = args[6];
- int dilation_h = args[7];
- int dilation_w = args[8];
- DLTensor* x = args[9];
- DLTensor* w = args[10];
- DLTensor* y = args[11];
- std::string conv_dtype = args[12];
-
+void ConvolutionForward(
+ int mode,
+ int format,
+ int algo,
+ const std::vector<int> pad,
Review comment:
pass by reference
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
