masahi commented on a change in pull request #4418: [RUNTIME] Add cudnn conv3d
URL: https://github.com/apache/incubator-tvm/pull/4418#discussion_r352031465
##########
File path: src/runtime/contrib/cudnn/conv_forward.cc
##########
@@ -120,137 +180,145 @@ TVM_REGISTER_GLOBAL("tvm.contrib.cudnn.conv2d.forward")
CuDNNDataType::GetConst<0>(entry_ptr->conv_entry.data_type),
entry_ptr->conv_entry.output_desc,
y->data));
-});
+}
-TVM_REGISTER_GLOBAL("tvm.contrib.cudnn.conv2d.output_shape")
-.set_body([](TVMArgs args, TVMRetValue *ret) {
+void OutputShape(
+ int format,
+ const std::vector<int> pad,
+ const std::vector<int> stride,
+ const std::vector<int> dilation,
+ const std::vector<int> x_dim,
+ const std::vector<int> w_dim,
Review comment:
pass by reference
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
