masahi commented on a change in pull request #4418: [RUNTIME] Add cudnn conv3d
URL: https://github.com/apache/incubator-tvm/pull/4418#discussion_r352095400
##########
File path: src/runtime/contrib/cudnn/conv_forward.cc
##########
@@ -287,6 +355,91 @@ TVM_REGISTER_GLOBAL("tvm.contrib.cudnn.conv2d.find_algo")
}
ret[0] = best_algo;
+}
+
+
+TVM_REGISTER_GLOBAL("tvm.contrib.cudnn.conv.forward")
+.set_body([](TVMArgs args, TVMRetValue *ret) {
+ int mode = args[0];
+ int format = args[1];
+ int algo = args[2];
+ int dims = args[3];
+
+ Array<Expr> pads = args[4];
+ Array<Expr> strides = args[5];
+ Array<Expr> dilations = args[6];
+
Review comment:
No that sounds bad. In the worst case we need to go back to explicitly
passing all values (i.e. we need to have separate conv2d_forward and
conv3d_forward)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
