comaniac commented on a change in pull request #4787: [Relay] Conv2D padding
representation
URL: https://github.com/apache/incubator-tvm/pull/4787#discussion_r372523989
##########
File path: python/tvm/relay/op/nn/nn.py
##########
@@ -202,6 +203,8 @@ def conv2d(data,
dilation = (dilation, dilation)
if isinstance(padding, int):
padding = (padding, padding)
+ # convert 2-way padding to 4-way padding
+ padding = get_pad_tuple(padding)
Review comment:
Since we also have conv1d and conv3d, maybe it's better to rename this
function to `get_2d_pad_tuple`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
