comaniac commented on a change in pull request #4787: [Relay] Conv2D padding
representation
URL: https://github.com/apache/incubator-tvm/pull/4787#discussion_r373193490
##########
File path: topi/python/topi/nn/conv2d.py
##########
@@ -62,6 +61,8 @@ def conv2d(input, filter, strides, padding, dilation,
layout='NCHW', out_dtype=N
output : tvm.Tensor
4-D with shape [batch, out_channel, out_height, out_width]
"""
+ #only accepts 4-way padding
+ assert len(padding) == 4, "only accepts 4-way padding"
Review comment:
@zxy844288792 how about we revert this file first and add a note in
`python/tvm/relay/op/nn/nn.py` to remind us to add it back when #4644 is merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
