comaniac commented on a change in pull request #4787: [Relay] Conv2D padding
representation
URL: https://github.com/apache/incubator-tvm/pull/4787#discussion_r373085568
##########
File path: topi/python/topi/nn/conv2d.py
##########
@@ -62,6 +61,8 @@ def conv2d(input, filter, strides, padding, dilation,
layout='NCHW', out_dtype=N
output : tvm.Tensor
4-D with shape [batch, out_channel, out_height, out_width]
"""
+ #only accepts 4-way padding
+ assert len(padding) == 4, "only accepts 4-way padding"
Review comment:
I'm afraid that you have to add this assertion to all conv2d compute
functions. Specifically, all conv2d functions with
`@autotvm.register_topi_compute(nn.conv2d, ...)` decorator should have this
assertion. @icemelon9 could you help confirm?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
