anijain2305 commented on issue #4873: [Relay][FastMath] Relay pass to use fast exp/tanh URL: https://github.com/apache/incubator-tvm/pull/4873#issuecomment-591052536 I investigated more. I am also little uncomfortable about adding another Relay build config option. It changes API of PassContext/BuildConfig object. Our goal is to make the pass user-friendly. We can use required_pass (current way) to do that. For a TVM user, there is no difference between the two options ### Current way ~~~ with relay.build_config(opt_level=3, required_pass=['FastMath']): ~~~ ### Alternative If we decide to add `enable_fast_math` build config option. ~~~ with relay.build_config(opt_level=3, enable_fast_math=True): ~~~ Since both are same from TVM user perspective, and current way does not change PassContext API, I feel more comfortable with current design. @zhiics @tqchen Let me know if this is ok.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
