anijain2305 commented on issue #4873: [Relay][FastMath] Relay pass to use fast exp/tanh URL: https://github.com/apache/incubator-tvm/pull/4873#issuecomment-591578182 @zhiics I agree we need more clarity over the usage of opt_level=4. Thinking more about this, I feel that opt_level=4 is more like a placeholder for all the passes, that will not be a part of default Relay build pipeline. I don't think we intend to use opt_level=4 to call these passes. Calling these passes should be either from outside or by using `required_pass`. If that is truly the case, maybe we should not even have an opt_level for such passes. As far as this PR is concerned, I think we are ok.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
