zhiics commented on issue #4873: [Relay][FastMath] Relay pass to use fast exp/tanh URL: https://github.com/apache/incubator-tvm/pull/4873#issuecomment-591168801 Adding it to `required_pass` sounds good to me as well since users definitely need to know what they do exactly in this scenario. The only concern I have is that I am not sure if we want to require passes from the higher level? Also, what's the relationship among the passes at opt_level=4? should we run it with other two passes when opt_level=4 is provided? This is not specific to this PR, but I think we probably want a better documentation for the choice of different opt levels.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
