comaniac commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591073220 IMHO, if you want to define a pattern by yourself, you should be clear about what can be supported and specify it in the pattern. Otherwise the scenario looks weird to me. Say you define a pattern to match an instruction, and merge composite generates a composite function accordingly. Later on we found that an op in this function does not fit an additional requirement. What should we do then? Should we decompose the function back to origin, or just left the composite function with your instruction attribute there without annotation? If we want to define a fuzzy pattern (e.g., an op in a pattern can be a set of candidates like your example, and you can somwhow specify the requirements for candiates), we should think about how to enhance pattern specification and pattern matching mechanism. This mechanism, however, does not have to be considered in this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
