zhiics commented on issue #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#issuecomment-591105578 @mbaret Thanks for all discussions. I think this is actually a separate issue to this PR. We probably want to have an RFC for it. We can say this PR mainly focuses on the annotation of operators, while currently composite isn't really an op but a function. We need to have some special `custom_op` to make op registration take it. But even if you have some ops in a composite function cannot be mapped to external codegen, this pass is still okay. For example, we can have a checker to see if we should add compiler annotations for it, this checker then could be a simple helper visitor.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
