icemelon9 commented on a change in pull request #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#discussion_r384133372
########## File path: python/tvm/relay/op/contrib/__init__.py ########## @@ -15,7 +15,8 @@ # specific language governing permissions and limitations # under the License. # pylint: disable=wildcard-import -"""Neural network related operators.""" -from __future__ import absolute_import as _abs -from .contrib import * +"""Contrib modules.""" Review comment: I feel this is a bad place to put dnnl in the contrib. Or maybe we should move the original `contrib` to another namespace. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
