masahi commented on a change in pull request #5142: [Torch] Add support for 
max_pool1d
URL: https://github.com/apache/incubator-tvm/pull/5142#discussion_r397049896
 
 

 ##########
 File path: src/relay/op/nn/pooling.cc
 ##########
 @@ -987,6 +987,10 @@ Array<te::Tensor> Pool1DCompute(const Attrs& attrs,
       << " or 4-D input (e.g. NCWc on for vector instructions)"
       << " or 5-D input (e.g. NCWnc for tensor accelerators)";
 
+  if (param->padding.size() == 1) {
+    padding.push_back(padding[0]);
 
 Review comment:
   Why do we need this? Does 1D pooling require two pad values (left & right)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to