wyc-ruiker commented on a change in pull request #5142: [Torch] Add support for max_pool1d URL: https://github.com/apache/incubator-tvm/pull/5142#discussion_r397074097
########## File path: tests/python/frontend/pytorch/test_forward.py ########## @@ -363,9 +363,35 @@ class MaxPool2D2(Module): def forward(self, *args): return torch.nn.MaxPool2d(kernel_size=[10, 10])(args[0]) + class MaxPool2D3(Module): Review comment: Don't we need a test for padding and stride in Maxpool? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services