wyc-ruiker commented on a change in pull request #5142: [Torch] Add support for
max_pool1d
URL: https://github.com/apache/incubator-tvm/pull/5142#discussion_r397071431
##########
File path: src/relay/op/nn/pooling.cc
##########
@@ -987,6 +987,10 @@ Array<te::Tensor> Pool1DCompute(const Attrs& attrs,
<< " or 4-D input (e.g. NCWc on for vector instructions)"
<< " or 5-D input (e.g. NCWnc for tensor accelerators)";
+ if (param->padding.size() == 1) {
+ padding.push_back(padding[0]);
Review comment:
Yes, If we don't have this, the max_pool1d will fail in
https://github.com/apache/incubator-tvm/blob/7c5ff50873e91e9ad27b5f08847c27d58e8b5c4c/topi/include/topi/nn/pooling.h#L679-L680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
