comaniac commented on a change in pull request #5195: [RELAY] Fixes to
MergeCompilerRegions
URL: https://github.com/apache/incubator-tvm/pull/5195#discussion_r401126984
##########
File path: src/relay/transforms/annotate_target.cc
##########
@@ -52,6 +55,13 @@ class AnnotateTargetWrapper : public ExprMutator {
return fannotate[op](call->attrs, call->args);
}
}
+ if (expr->IsInstance<TupleGetItemNode>()) {
Review comment:
I have a concern about this. It seems like you have to list all possible
nodes here and it's easy to miss something. For now I would suggest adding an
exception at least to indicate that we need to add more here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
