trevor-m commented on a change in pull request #5195: [RELAY] Fixes to 
MergeCompilerRegions
URL: https://github.com/apache/incubator-tvm/pull/5195#discussion_r401175060
 
 

 ##########
 File path: src/relay/transforms/annotate_target.cc
 ##########
 @@ -52,6 +55,13 @@ class AnnotateTargetWrapper : public ExprMutator {
         return fannotate[op](call->attrs, call->args);
       }
     }
+    if (expr->IsInstance<TupleGetItemNode>()) {
 
 Review comment:
   I don't think that many nodes will need to be supported here. 
TupleGetItemNode is needed for batchnorm. I have a PR ready to add support for 
TupleNode which is needed for concatenate. I haven't encountered any other 
nodes yet that would need to be added here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to