zhiics commented on a change in pull request #5195: [RELAY] Fixes to
MergeCompilerRegions
URL: https://github.com/apache/incubator-tvm/pull/5195#discussion_r401116877
##########
File path: src/relay/analysis/annotated_region_set.cc
##########
@@ -73,7 +73,7 @@ void AnnotatedRegionSetNode::MergeRegions(AnnotatedRegion
src,
void AnnotatedRegionSetNode::AddToRegion(AnnotatedRegion region, const Expr&
expr) {
auto region2 = GetRegion(expr);
if (region2.defined()) {
- MergeRegions(region, region2);
+ MergeRegions(region2, region);
Review comment:
I would suggest we use `src` and `dst` to reduce the confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
