tqchen commented on code in PR #15244:
URL: https://github.com/apache/tvm/pull/15244#discussion_r1297137577
##########
src/support/base64.h:
##########
@@ -293,6 +293,40 @@ class Base64OutStream : public dmlc::Stream {
}
}
};
+
+inline size_t b64strlen(const std::string b64str) {
+ ICHECK(b64str.size() % 4 == 0) << "invalid base64 encoding";
Review Comment:
Move these two functions to callers, since they are not necessarily the
optimal way of decoding b64. The b64Stream is the preferred way. So avoid
making them in support(and gradually we move the contrib impl over, or keep
them self-contained to a sub module scope) is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
