sunggg commented on code in PR #15244:
URL: https://github.com/apache/tvm/pull/15244#discussion_r1292843205
##########
src/node/structural_hash.cc:
##########
@@ -360,6 +361,39 @@ struct ADTObjTrait {
TVM_REGISTER_REFLECTION_VTABLE(runtime::ADTObj, ADTObjTrait);
+struct ModuleNodeTrait {
+ static constexpr const std::nullptr_t VisitAttrs = nullptr;
+ static void SHashReduce(const runtime::ModuleNode* key, SHashReducer
hash_reduce) {
Review Comment:
> avoid structural equality check of runtime module as it is not guaranteed
to be valid for all.
Is it because runtime module is not always binary serializable? If so,
current design would raise an error within the structural equality. I assumed
the serialization is always deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
