tqchen commented on code in PR #15244:
URL: https://github.com/apache/tvm/pull/15244#discussion_r1292524901
##########
src/target/codegen.cc:
##########
@@ -83,17 +89,20 @@ class ModuleSerializer {
for (const auto& group : mod_group_vec_) {
ICHECK_NE(group.size(), 0) << "Every allocated group must have at least
one module";
- if (!group[0]->IsDSOExportable()) {
+ if (group[0]->IsBinarySerializable()) {
Review Comment:
When we are in export_dso mode, we should first check if it is
IsDSOExportable,
```c++
if (export_dso) {
// prioritize export dso when a module is both serializable and
exportable
if (group[0]->IsDSOExportable()) {
} else if (group[0]->IsBinarySerializable()) {
}
} else {
CHECK(group[0]->IsBinarySerializable());
}
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
