slyubomirsky commented on code in PR #15697:
URL: https://github.com/apache/tvm/pull/15697#discussion_r1326009383


##########
tests/python/relax/test_transform_lazy_transform_params.py:
##########
@@ -137,10 +136,8 @@ def slice_buffer(
 
     @I.ir_module
     class Expected:
-        @R.function
+        @R.function(pure=False)
         def main_transform_params(slice_shape_expr: R.Shape(["slice_index"])):
-            # we expect ToNonDataflow and RemovePurityTracking to be invoked 
first

Review Comment:
   Where does `LazyTransformParams` fall in the phase ordering? Do we expect it 
to be used early or late in compilation?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to