slyubomirsky commented on code in PR #15697:
URL: https://github.com/apache/tvm/pull/15697#discussion_r1329157255
##########
tests/python/relax/test_transform_lazy_transform_params.py:
##########
@@ -137,10 +136,8 @@ def slice_buffer(
@I.ir_module
class Expected:
- @R.function
+ @R.function(pure=False)
def main_transform_params(slice_shape_expr: R.Shape(["slice_index"])):
- # we expect ToNonDataflow and RemovePurityTracking to be invoked
first
Review Comment:
Ah, that's interesting. I would still call it pure since it's not modifying
any state (as distinct from, say, a call to a random number generator that
modifies the internal state of the generator), but the dependency on external
state is a potential bit of trickiness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
