Lunderberg commented on code in PR #15697:
URL: https://github.com/apache/tvm/pull/15697#discussion_r1327799351
##########
tests/python/relax/test_transform_lazy_transform_params.py:
##########
@@ -137,10 +136,8 @@ def slice_buffer(
@I.ir_module
class Expected:
- @R.function
+ @R.function(pure=False)
def main_transform_params(slice_shape_expr: R.Shape(["slice_index"])):
- # we expect ToNonDataflow and RemovePurityTracking to be invoked
first
Review Comment:
It wouldn't be impure due to side effects, but impure due to failure to
return the same result for each execution. Because the model weights are no
longer expressed as input arguments, they rely on external state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
